Skip to content

fix(raw_transfer): disable layout assertions on some 32-bit platforms #13716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Sep 12, 2025
Merged

fix(raw_transfer): disable layout assertions on some 32-bit platforms #13716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_allocator/src/generated/assert_layouts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const _: () = {
};

#[cfg(target_pointer_width = "32")]
const _: () = {
const _: () = if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
// Padding: 3 bytes
assert!(size_of::<FixedSizeAllocatorMetadata>() == 12);
assert!(align_of::<FixedSizeAllocatorMetadata>() == 4);
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_ast/src/generated/assert_layouts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,7 +1612,7 @@ const _: () = {
};

#[cfg(target_pointer_width = "32")]
const _: () = {
const _: () = if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
// Padding: 1 bytes
assert!(size_of::<Program>() == 88);
assert!(align_of::<Program>() == 4);
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/generated/assert_layouts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const _: () = {
};

#[cfg(target_pointer_width = "32")]
const _: () = {
const _: () = if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
// Padding: 3 bytes
assert!(size_of::<RawTransferMetadata2>() == 16);
assert!(align_of::<RawTransferMetadata2>() == 8);
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_regular_expression/src/generated/assert_layouts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ const _: () = {
};

#[cfg(target_pointer_width = "32")]
const _: () = {
const _: () = if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
// Padding: 0 bytes
assert!(size_of::<Pattern>() == 32);
assert!(align_of::<Pattern>() == 4);
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_span/src/generated/assert_layouts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const _: () = {
};

#[cfg(target_pointer_width = "32")]
const _: () = {
const _: () = if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
// Padding: 0 bytes
assert!(size_of::<Span>() == 8);
assert!(align_of::<Span>() == 4);
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_syntax/src/generated/assert_layouts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ const _: () = {
};

#[cfg(target_pointer_width = "32")]
const _: () = {
const _: () = if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
// Padding: 0 bytes
assert!(size_of::<NonMaxU32>() == 4);
assert!(align_of::<NonMaxU32>() == 4);
Expand Down
2 changes: 1 addition & 1 deletion napi/parser/src/generated/assert_layouts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const _: () = {
};

#[cfg(target_pointer_width = "32")]
const _: () = {
const _: () = if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
// Padding: 0 bytes
assert!(size_of::<RawTransferData>() == 188);
assert!(align_of::<RawTransferData>() == 4);
Expand Down
13 changes: 12 additions & 1 deletion tasks/ast_tools/src/generators/assert_layouts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,9 +684,20 @@ fn template(krate: &str, assertions_64: &TokenStream, assertions_32: &TokenStrea
#[cfg(target_pointer_width = "64")]
const _: () = { #assertions_64 };

// Some 32-bit platforms have 8-byte alignment for `u64` and `f64`, while others have 4-byte alignment.
//
// Skip these assertions on 32-bit platforms where `u64` / `f64` have 4-byte alignment, because
// some layout calculations may be incorrect. https://github.com/oxc-project/oxc/issues/13694
//
// At present 32-bit layouts aren't relied on by any code, so it's fine if they're incorrect for now.
// However, raw transfer will be supported on WASM32 in future, and layout calculations are correct
// for WASM32 at present. So keep these assertions for WASM, to ensure changes to AST or this codegen
// don't break anything.
///@@line_break
#[cfg(target_pointer_width = "32")]
const _: () = { #assertions_32 };
const _: () = if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
#assertions_32
};

///@@line_break
#[cfg(not(any(target_pointer_width = "64", target_pointer_width = "32")))]
Expand Down
Loading