Skip to content

Comments

test(napi/oxlint): add tests for without JS plugins enabled#13698

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-12-test_napi_oxlint_add_tests_for_without_js_plugins_enabled
Sep 12, 2025
Merged

test(napi/oxlint): add tests for without JS plugins enabled#13698
graphite-app[bot] merged 1 commit intomainfrom
09-12-test_napi_oxlint_add_tests_for_without_js_plugins_enabled

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 11, 2025

Add a couple of tests to make sure napi/oxlint operates correctly without --experimental-js-plugins CLI option.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Sep 11, 2025
Copy link
Member Author

overlookmotel commented Sep 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add some tests for the error flows (low priority)

i.e. what happens when you run oxlint without --experimental... but yoy have plugins configured

@camc314 camc314 added A-linter Area - Linter 0-merge Merge with Graphite Merge Queue labels Sep 12, 2025
Copy link
Contributor

camc314 commented Sep 12, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 12, 2025
@overlookmotel overlookmotel changed the base branch from 09-11-build_napi_oxlint_flatten_dist_directory_structure to graphite-base/13698 September 12, 2025 03:54
@overlookmotel overlookmotel force-pushed the 09-12-test_napi_oxlint_add_tests_for_without_js_plugins_enabled branch from 1313199 to b6e3fbb Compare September 12, 2025 04:03
@overlookmotel overlookmotel changed the base branch from graphite-base/13698 to 09-11-build_napi_oxlint_flatten_dist_directory_structure September 12, 2025 04:03
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 12, 2025
@overlookmotel
Copy link
Member Author

overlookmotel commented Sep 12, 2025

should we add some tests for the error flows (low priority)

Yes, definitely.

i.e. what happens when you run oxlint without --experimental... but yoy have plugins configured

That test is added in next PR #13699.

@overlookmotel overlookmotel force-pushed the 09-12-test_napi_oxlint_add_tests_for_without_js_plugins_enabled branch from b6e3fbb to 99264be Compare September 12, 2025 04:18
@overlookmotel overlookmotel force-pushed the 09-11-build_napi_oxlint_flatten_dist_directory_structure branch from ba288b8 to 9c52c20 Compare September 12, 2025 04:18
Add a couple of tests to make sure `napi/oxlint` operates correctly without `--experimental-js-plugins` CLI option.
@graphite-app graphite-app bot force-pushed the 09-11-build_napi_oxlint_flatten_dist_directory_structure branch from 9c52c20 to 3f84157 Compare September 12, 2025 04:20
@graphite-app graphite-app bot force-pushed the 09-12-test_napi_oxlint_add_tests_for_without_js_plugins_enabled branch from 99264be to 9126c93 Compare September 12, 2025 04:20
Base automatically changed from 09-11-build_napi_oxlint_flatten_dist_directory_structure to main September 12, 2025 04:24
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 12, 2025
@graphite-app graphite-app bot merged commit 9126c93 into main Sep 12, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 09-12-test_napi_oxlint_add_tests_for_without_js_plugins_enabled branch September 12, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants