perf(codegen): reduce memory usage in SourcemapBuilder#13679
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 11, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-codegen
CodSpeed Instrumentation Performance ReportMerging #13679 will not alter performanceComparing Summary
Footnotes |
Member
Merge activity
|
#13670 optimized `SourcemapBuilder` to pre-reserve capacity in `columns` `Vec`. However, after #13677, `columns` will resize adaptively depending on how many unicode chars in source text. So now initial capacity of 256 (1 KiB) is probably excessive for most cases. Reduce it to 16 (64 bytes, which is 1 x CPU cache line). Codspeed shows little change in perf (max +0.1%, min -0.1%), and memory usage will definitely be reduced.
graphite-app
bot
force-pushed
the
09-11-perf_codegen_reduce_allocations_in_sourcemapbuilder_
branch
from
3613afd to
4ded22b
Compare
graphite-app
bot
force-pushed
the
09-11-perf_codegen_reduce_memory_usage_in_sourcemapbuilder_
branch
from
02da60b to
d4608f1
Compare
Base automatically changed from
09-11-perf_codegen_reduce_allocations_in_sourcemapbuilder_
to
main
September 11, 2025 07:36
graphite-app
bot
deleted the
09-11-perf_codegen_reduce_memory_usage_in_sourcemapbuilder_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13670 optimized
SourcemapBuilderto pre-reserve capacity incolumnsVec.However, after #13677,
columnswill resize adaptively depending on how many unicode chars in source text. So now initial capacity of 256 (1 KiB) is probably excessive for most cases. Reduce it to 16 (64 bytes, which is 1 x CPU cache line).Codspeed shows little change in perf (max +0.1%, min -0.1%), and memory usage will definitely be reduced.