refactor(linter_codegen): split into separate files#13657
refactor(linter_codegen): split into separate files#13657graphite-app[bot] merged 1 commit intomainfrom
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
d0b309f to
ab01e3a
Compare
There was a problem hiding this comment.
Pull Request Overview
Pure refactoring to split the linter codegen into separate modules for better organization and to enable easier addition of new "detectors" for rule runner implementation generation.
- Split a monolithic file into organized modules (utils, rules, node_type_set, if_else_detector)
- Moved utility functions, rule parsing logic, and node type detection into dedicated modules
- Updated imports and visibility modifiers to support the new modular structure
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/linter_codegen/src/main.rs | Removed large chunks of code that were moved to separate modules and updated imports |
| tasks/linter_codegen/src/utils.rs | New module containing utility functions for AST parsing and rule analysis |
| tasks/linter_codegen/src/rules.rs | New module containing rule entry definitions and rule parsing logic |
| tasks/linter_codegen/src/node_type_set.rs | New module containing the NodeTypeSet struct and its methods |
| tasks/linter_codegen/src/if_else_detector.rs | New module containing the IfElseKindDetector for analyzing if-else patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
Pure refactoring. Just splitting up the linter codegen into individual files to make it a little more organized. This will make it easier to add more "detectors" (I guess that's what we'll call them for now) for additional types of syntax for generating rule runner impls.
ab01e3a to
53f5218
Compare

Pure refactoring. Just splitting up the linter codegen into individual files to make it a little more organized. This will make it easier to add more "detectors" (I guess that's what we'll call them for now) for additional types of syntax for generating rule runner impls.