Skip to content

perf(linter): remove unnecessary should_run check #13639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Sep 10, 2025
Merged

perf(linter): remove unnecessary should_run check #13639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions crates/oxc_linter/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,14 +191,12 @@ impl Linter {
let rule = *rule;
// Collect node type information for rules. In large files, benchmarking showed it was worth
// collecting rules into buckets by AST node type to avoid iterating over all rules for each node.
if rule.should_run(&ctx_host) {
if let Some(ast_types) = rule.types_info() {
for ty in ast_types {
rules_by_ast_type[ty as usize].push((rule, ctx));
}
} else {
rules_any_ast_type.push((rule, ctx));
if let Some(ast_types) = rule.types_info() {
for ty in ast_types {
rules_by_ast_type[ty as usize].push((rule, ctx));
}
} else {
rules_any_ast_type.push((rule, ctx));
}

rule.run_once(ctx);
Expand Down
Loading