perf(parser): store Option<diagnostic> for lexer errors

[camc314]

partially addresses the perf regression in #13494

Not quite as fast as originally, but a little bit faster

[camc314]

• perf test 2 #13521
• perf(parser): store Option<diagnostic> for lexer errors #13520 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13520 will not alter performance

_{Comparing c/09-02-perf_test (3ead0dd) with main (53f2fc1)¹}

Summary

✅ 37 untouched benchmarks

Footnotes

1. No successful run was found on main (3ead0dd) during the generation of this report, so 53f2fc1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Boshen]

Merge activity

• Sep 2, 4:45 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Sep 2, 4:45 PM UTC: Boshen added this pull request to the Graphite merge queue.
• Sep 2, 4:50 PM UTC: Merged by the Graphite merge queue.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.