Skip to content

Comments

feat(minifier): return total iterations ran for DCE as well#13476

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-31-feat_minifier_return_total_iterations_ran_for_dce_as_well
Aug 31, 2025
Merged

feat(minifier): return total iterations ran for DCE as well#13476
graphite-app[bot] merged 1 commit intomainfrom
08-31-feat_minifier_return_total_iterations_ran_for_dce_as_well

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 31, 2025

It was returning 1 instead of the actual total interations.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Aug 31, 2025
Copy link
Member Author

sapphi-red commented Aug 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red force-pushed the 08-31-feat_minifier_respect_--max-iterations_for_dce_as_well branch from 260687f to 7fdcfc5 Compare August 31, 2025 13:00
@sapphi-red sapphi-red force-pushed the 08-31-feat_minifier_return_total_iterations_ran_for_dce_as_well branch from b2595f5 to 7c96301 Compare August 31, 2025 13:00
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 31, 2025

CodSpeed Instrumentation Performance Report

Merging #13476 will not alter performance

Comparing 08-31-feat_minifier_return_total_iterations_ran_for_dce_as_well (78dcfc6) with main (5990f17)1

Summary

✅ 37 untouched benchmarks

Footnotes

  1. No successful run was found on main (78dcfc6) during the generation of this report, so 5990f17 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red sapphi-red marked this pull request as ready for review August 31, 2025 13:19
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
Copy link
Member

Boshen commented Aug 31, 2025

Merge activity

It was returning `1` instead of the actual total interations.
@graphite-app graphite-app bot force-pushed the 08-31-feat_minifier_respect_--max-iterations_for_dce_as_well branch from 7fdcfc5 to ecf69bb Compare August 31, 2025 15:03
@graphite-app graphite-app bot force-pushed the 08-31-feat_minifier_return_total_iterations_ran_for_dce_as_well branch from 7c96301 to 78dcfc6 Compare August 31, 2025 15:03
Base automatically changed from 08-31-feat_minifier_respect_--max-iterations_for_dce_as_well to main August 31, 2025 15:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
@graphite-app graphite-app bot merged commit 78dcfc6 into main Aug 31, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-31-feat_minifier_return_total_iterations_ran_for_dce_as_well branch August 31, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants