Skip to content

fix(regular_expression): don't lower capture groups that are not named ones#13469

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-31-fix_regular_expression_don_t_lower_capture_groups_that_are_not_named_ones
Aug 31, 2025
Merged

fix(regular_expression): don't lower capture groups that are not named ones#13469
graphite-app[bot] merged 1 commit intomainfrom
08-31-fix_regular_expression_don_t_lower_capture_groups_that_are_not_named_ones

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 31, 2025

Capture groups that are not named ones are lowered even though it's not needed to.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Aug 31, 2025
Copy link
Member Author

sapphi-red commented Aug 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 31, 2025

CodSpeed Instrumentation Performance Report

Merging #13469 will not alter performance

Comparing 08-31-fix_regular_expression_don_t_lower_capture_groups_that_are_not_named_ones (0eea7da) with main (946669b)1

Summary

✅ 37 untouched benchmarks

Footnotes

  1. No successful run was found on main (c17b80a) during the generation of this report, so 946669b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red sapphi-red force-pushed the 08-31-fix_regular_expression_don_t_lower_capture_groups_that_are_not_named_ones branch from 77c2b50 to f91dd70 Compare August 31, 2025 11:37
@sapphi-red sapphi-red marked this pull request as draft August 31, 2025 11:38
@sapphi-red sapphi-red force-pushed the 08-31-fix_regular_expression_don_t_lower_capture_groups_that_are_not_named_ones branch 3 times, most recently from 7b9dd09 to a21c52c Compare August 31, 2025 12:02
@sapphi-red sapphi-red marked this pull request as ready for review August 31, 2025 12:10
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 31, 2025

Merge activity

…d ones (#13469)

Capture groups that are not named ones are lowered even though it's not needed to.
@graphite-app graphite-app bot force-pushed the 08-31-refactor_regular_expression_extract_has_unsupported_regular_expression_pattern_ branch from 7f1885c to c17b80a Compare August 31, 2025 15:16
@graphite-app graphite-app bot force-pushed the 08-31-fix_regular_expression_don_t_lower_capture_groups_that_are_not_named_ones branch from a21c52c to 0eea7da Compare August 31, 2025 15:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
Base automatically changed from 08-31-refactor_regular_expression_extract_has_unsupported_regular_expression_pattern_ to main August 31, 2025 15:21
@graphite-app graphite-app bot merged commit 0eea7da into main Aug 31, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-31-fix_regular_expression_don_t_lower_capture_groups_that_are_not_named_ones branch August 31, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant