Skip to content

Comments

fix(semantic): allow super in object literal method inside a class#13463

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-31-fix_semantic_allow_super_in_object_literal_method_inside_a_class
Aug 31, 2025
Merged

fix(semantic): allow super in object literal method inside a class#13463
graphite-app[bot] merged 1 commit intomainfrom
08-31-fix_semantic_allow_super_in_object_literal_method_inside_a_class

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 31, 2025

fixes #13284

@Boshen Boshen requested a review from Dunqing as a code owner August 31, 2025 10:42
@Boshen Boshen requested a review from overlookmotel August 31, 2025 10:42
@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Aug 31, 2025
Copy link
Member Author

Boshen commented Aug 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 31, 2025

CodSpeed Instrumentation Performance Report

Merging #13463 will not alter performance

Comparing 08-31-fix_semantic_allow_super_in_object_literal_method_inside_a_class (dc9645f) with main (2096ef4)1

Summary

✅ 37 untouched benchmarks

Footnotes

  1. No successful run was found on main (dc9645f) during the generation of this report, so 2096ef4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many edges cases with this damn thing. Some test cases are now passing which should fail. I'll follow-up with another PR to hopefully clean up the last oddities.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
Copy link
Member

overlookmotel commented Aug 31, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-31-fix_semantic_allow_super_in_object_literal_method_inside_a_class branch from 185fc16 to dc9645f Compare August 31, 2025 21:06
@graphite-app graphite-app bot merged commit dc9645f into main Aug 31, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-31-fix_semantic_allow_super_in_object_literal_method_inside_a_class branch August 31, 2025 21:12
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

semantic: discrepancies in super diagnostics compared to TypeScript

2 participants