Skip to content

fix(tasks/allocations): before minification, transform to esnext#13445

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/08-30-fix_tasks_allocations_before_minification_transform_to_esnext
Sep 11, 2025
Merged

fix(tasks/allocations): before minification, transform to esnext#13445
graphite-app[bot] merged 1 commit intomainfrom
c/08-30-fix_tasks_allocations_before_minification_transform_to_esnext

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Aug 30, 2025

No description provided.

@github-actions github-actions bot added the C-bug Category - Bug label Aug 30, 2025
Copy link
Contributor Author

camc314 commented Aug 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/08-30-fix_tasks_allocations_before_minification_transform_to_esnext branch from c1edcd5 to 89925c8 Compare August 30, 2025 17:20
@camc314 camc314 marked this pull request as ready for review August 30, 2025 17:21
Copilot AI review requested due to automatic review settings August 30, 2025 17:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds TypeScript to ESNext transformation before minification in the memory allocation tracking task. The minifier requires code to be in ESNext format, so TypeScript files need to be transformed before they can be minified.

  • Adds transformation step before minification to convert TypeScript to ESNext
  • Updates dependencies to include semantic analysis and transformer components
  • Updates memory allocation benchmarks to reflect the new transformation step

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
tasks/track_memory_allocations/src/lib.rs Adds transformation logic and required imports
tasks/track_memory_allocations/Cargo.toml Adds semantic and transformer dependencies
tasks/track_memory_allocations/allocs_minifier.snap Updates memory allocation benchmarks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 30, 2025

CodSpeed Instrumentation Performance Report

Merging #13445 will not alter performance

Comparing c/08-30-fix_tasks_allocations_before_minification_transform_to_esnext (5f822c1) with main (7775c21)1

Summary

✅ 37 untouched benchmarks

Footnotes

  1. No successful run was found on main (5f822c1) during the generation of this report, so 7775c21 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
Copy link
Member

Boshen commented Aug 31, 2025

Merge activity

  • Aug 31, 5:10 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 31, 5:10 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Aug 31, 5:10 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Aug 31, 5:10 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 31, 5:44 AM UTC: Boshen added this pull request to the Graphite merge queue.
  • Aug 31, 5:45 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Sep 11, 6:49 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 11, 6:49 AM UTC: Boshen added this pull request to the Graphite merge queue.
  • Sep 11, 6:59 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
@camc314 camc314 force-pushed the c/08-30-fix_tasks_allocations_before_minification_transform_to_esnext branch from 89925c8 to 038524f Compare September 11, 2025 05:26
@camc314 camc314 requested a review from Boshen September 11, 2025 05:26
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 11, 2025
@graphite-app graphite-app bot force-pushed the c/08-30-fix_tasks_allocations_before_minification_transform_to_esnext branch from 038524f to 5f822c1 Compare September 11, 2025 06:54
@graphite-app graphite-app bot merged commit 5f822c1 into main Sep 11, 2025
26 checks passed
@graphite-app graphite-app bot deleted the c/08-30-fix_tasks_allocations_before_minification_transform_to_esnext branch September 11, 2025 06:59
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants