Skip to content

perf(codegen): use isize for quote counters #13441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 31, 2025
Merged

perf(codegen): use isize for quote counters #13441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions crates/oxc_codegen/src/str.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,13 @@ impl PrintStringState<'_> {

/// Calculate optimum quote character to use, when backtick (`) is an option.
fn calculate_quote_maybe_backtick(&self) -> Quote {
// String length is max `u32::MAX`, so use `i64` to make overflow impossible
let mut single_cost: i64 = 0;
let mut double_cost: i64 = 0;
let mut backtick_cost: i64 = 0;
// Max string length is:
// * 64-bit platforms: `u32::MAX`.
// * 32-bit platforms: `i32::MAX`.
// In either case, `isize` is sufficient to make overflow impossible.
let mut single_cost: isize = 0;
let mut double_cost: isize = 0;
let mut backtick_cost: isize = 0;
let mut bytes = self.bytes.clone();
while let Some(b) = bytes.next() {
match b {
Expand Down Expand Up @@ -264,8 +267,11 @@ impl PrintStringState<'_> {

/// Calculate optimum quote character to use, when backtick (`) is not an option.
fn calculate_quote_no_backtick(&self) -> Quote {
// String length is max `u32::MAX`, so `i64` cannot overflow
let mut single_cost: i64 = 0;
// Max string length is:
// * 64-bit platforms: `u32::MAX`.
// * 32-bit platforms: `i32::MAX`.
// In either case, `isize` is sufficient to make overflow impossible.
let mut single_cost: isize = 0;
for &b in self.bytes.clone() {
match b {
b'\'' => single_cost += 1,
Expand Down
Loading