feat(allocs): track allocations for minifier#13408
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 30, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camchenry
force-pushed
the
08-29-feat_allocs_track_allocations_for_minifier
branch
from
9534327 to
516a45a
Compare
camchenry
force-pushed
the
08-29-refactor_allocs_allow_capturing_multiple_stats_at_once
branch
from
a6ba8d3 to
e8e5c96
Compare
CodSpeed Instrumentation Performance ReportMerging #13408 will not alter performanceComparing Summary
Footnotes |
camchenry
force-pushed
the
08-29-feat_allocs_track_allocations_for_minifier
branch
2 times, most recently
from
6c99a9d to
294ba18
Compare
camchenry
force-pushed
the
08-29-feat_allocs_track_allocations_for_minifier
branch
from
294ba18 to
010245a
Compare
camchenry
force-pushed
the
08-29-refactor_allocs_allow_capturing_multiple_stats_at_once
branch
from
e8e5c96 to
2bb988d
Compare
Member
Merge activity
|
cc @Boshen I saw lots of changes going on in the minifier. Thought this might be helpful for tracking any allocation changes in the minifier that might regress/improve performance.
graphite-app
bot
force-pushed
the
08-29-refactor_allocs_allow_capturing_multiple_stats_at_once
branch
from
2bb988d to
9f53c04
Compare
graphite-app
bot
force-pushed
the
08-29-feat_allocs_track_allocations_for_minifier
branch
from
010245a to
178b3e7
Compare
Base automatically changed from
08-29-refactor_allocs_allow_capturing_multiple_stats_at_once
to
main
August 30, 2025 14:18
graphite-app
bot
deleted the
08-29-feat_allocs_track_allocations_for_minifier
branch
overlookmotel
added a commit
that referenced
this pull request
Aug 30, 2025
#13408 introduced allocation tracking for minifier. However, it's causing panics when minifying TS files. I think problem is that minifier cannot handle TS. Probably a better solution would be to put TS code through transformer before minifying, to remove TS syntax. But doing this easier fix for now, just to get CI green again, and allow other PRs to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Boshen I saw lots of changes going on in the minifier. Thought this might be helpful for tracking any allocation changes in the minifier that might regress/improve performance.