Skip to content

Comments

refactor(linter/jsx-handler-names): simplify option checks for inline functions and local variables#13405

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/08-29-refactor_linter_jsx-handler-names_simplify_option_checks_for_inline_functions_and_local_variables
Aug 29, 2025
Merged

refactor(linter/jsx-handler-names): simplify option checks for inline functions and local variables#13405
graphite-app[bot] merged 1 commit intomainfrom
c/08-29-refactor_linter_jsx-handler-names_simplify_option_checks_for_inline_functions_and_local_variables

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Aug 29, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 29, 2025
Copy link
Contributor Author

camc314 commented Aug 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review August 29, 2025 18:01
Copilot AI review requested due to automatic review settings August 29, 2025 18:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the option parsing logic for the jsx-handler-names linter rule by using method chaining instead of nested if-let statements for boolean options.

  • Refactored nested if-let statements to use .and_then() method chaining for cleaner code
  • Removed redundant intermediate variable assignments and nested scoping

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 29, 2025

CodSpeed Instrumentation Performance Report

Merging #13405 will not alter performance

Comparing c/08-29-refactor_linter_jsx-handler-names_simplify_option_checks_for_inline_functions_and_local_variables (d499400) with main (62da550)1

Summary

✅ 38 untouched benchmarks

Footnotes

  1. No successful run was found on main (d499400) during the generation of this report, so 62da550 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 force-pushed the c/08-29-refactor_linter_jsx-handler-names_simplify_option_checks_for_inline_functions_and_local_variables branch from 1eeae04 to 4879756 Compare August 29, 2025 18:34
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 29, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/08-29-refactor_linter_jsx-handler-names_simplify_option_checks_for_inline_functions_and_local_variables branch from 4879756 to d499400 Compare August 29, 2025 18:38
@graphite-app graphite-app bot merged commit d499400 into main Aug 29, 2025
24 checks passed
@graphite-app graphite-app bot deleted the c/08-29-refactor_linter_jsx-handler-names_simplify_option_checks_for_inline_functions_and_local_variables branch August 29, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant