Skip to content

Comments

feat(ecmascript): check side effects inside static blocks#13404

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-30-feat_ecmascript_check_side_effects_inside_static_blocks
Aug 30, 2025
Merged

feat(ecmascript): check side effects inside static blocks#13404
graphite-app[bot] merged 1 commit intomainfrom
08-30-feat_ecmascript_check_side_effects_inside_static_blocks

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 29, 2025

Now that we have MayHaveSideEffects for Statements, we can check the static block.

Copy link
Member Author

sapphi-red commented Aug 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Aug 29, 2025
@sapphi-red sapphi-red marked this pull request as ready for review August 29, 2025 17:57
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 29, 2025

CodSpeed Instrumentation Performance Report

Merging #13404 will not alter performance

Comparing 08-30-feat_ecmascript_check_side_effects_inside_static_blocks (95d4311) with main (5d74332)1

Summary

✅ 38 untouched benchmarks

Footnotes

  1. No successful run was found on main (2d0414d) during the generation of this report, so 5d74332 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red sapphi-red force-pushed the 08-30-feat_ecmascript_check_side_effects_inside_static_blocks branch from 73c11fa to 1944035 Compare August 29, 2025 18:02
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 30, 2025
Copy link
Member

Boshen commented Aug 30, 2025

Merge activity

Now that we have `MayHaveSideEffects` for Statements, we can check the static block.
@graphite-app graphite-app bot force-pushed the 08-30-feat_minifier_remove_pure_function_calls_when_the_return_value_is_not_used branch from d68f127 to 2d0414d Compare August 30, 2025 04:16
@graphite-app graphite-app bot force-pushed the 08-30-feat_ecmascript_check_side_effects_inside_static_blocks branch from 1944035 to 95d4311 Compare August 30, 2025 04:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 30, 2025
Base automatically changed from 08-30-feat_minifier_remove_pure_function_calls_when_the_return_value_is_not_used to main August 30, 2025 04:22
@graphite-app graphite-app bot merged commit 95d4311 into main Aug 30, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-30-feat_ecmascript_check_side_effects_inside_static_blocks branch August 30, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants