Skip to content

fix(minifier): keep argument spread side effects against empty functions #13401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 30, 2025
Merged

fix(minifier): keep argument spread side effects against empty functions #13401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions crates/oxc_minifier/src/peephole/remove_dead_code.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,22 +416,13 @@ impl<'a> PeepholeOptimizations {
if let Some(reference_id) = ident.reference_id.get() {
if let Some(symbol_id) = ctx.scoping().get_reference(reference_id).symbol_id() {
if ctx.state.empty_functions.contains(&symbol_id) {
if e.arguments.is_empty() {
let mut exprs =
Self::fold_arguments_into_needed_expressions(&mut e.arguments, ctx);
if exprs.is_empty() {
*expr = ctx.ast.void_0(e.span);
ctx.state.changed = true;
return;
}
let mut exprs = ctx.ast.vec();
for arg in e.arguments.drain(..) {
match arg {
Argument::SpreadElement(e) => {
exprs.push(e.unbox().argument);
}
match_expression!(Argument) => {
exprs.push(arg.into_expression());
}
}
}
exprs.push(ctx.ast.void_0(e.span));
*expr = ctx.ast.expression_sequence(e.span, exprs);
ctx.state.changed = true;
Expand Down Expand Up @@ -724,8 +715,8 @@ mod test {
test_options("var foo = () => {}; foo()", "", &options);
test_options("var foo = () => {}; foo(a)", "a", &options);
test_options("var foo = () => {}; foo(a, b)", "a, b", &options);
test_options("var foo = () => {}; foo(...a, b)", "a, b", &options);
test_options("var foo = () => {}; foo(...a, ...b)", "a, b", &options);
test_options("var foo = () => {}; foo(...a, b)", "[...a], b", &options);
test_options("var foo = () => {}; foo(...a, ...b)", "[...a], [...b]", &options);
test_options("var foo = () => {}; x = foo()", "x = void 0", &options);
test_options("var foo = () => {}; x = foo(a(), b())", "x = (a(), b(), void 0)", &options);
test_options("var foo = function () {}; foo()", "", &options);
Expand Down
3 changes: 1 addition & 2 deletions crates/oxc_minifier/src/peephole/remove_unused_expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,9 +580,8 @@ impl<'a> PeepholeOptimizations {
!call_expr.may_have_side_effects(ctx)
}

fn fold_arguments_into_needed_expressions(
pub fn fold_arguments_into_needed_expressions(
args: &mut Vec<'a, Argument<'a>>,

ctx: &mut Ctx<'a, '_>,
) -> Vec<'a, Expression<'a>> {
ctx.ast.vec_from_iter(args.drain(..).filter_map(|arg| {
Expand Down
Loading