Skip to content

Comments

test(oxc_linter): run from_tsgo_lint_diagnostic tests only with lsp feature flag#13396

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-29-test_oxc_linter_run_from_tsgo_lint_diagnostic_tests_only_with_lsp_feature_flag
Aug 29, 2025
Merged

test(oxc_linter): run from_tsgo_lint_diagnostic tests only with lsp feature flag#13396
graphite-app[bot] merged 1 commit intomainfrom
08-29-test_oxc_linter_run_from_tsgo_lint_diagnostic_tests_only_with_lsp_feature_flag

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Aug 29, 2025

follow up from #13374

@github-actions github-actions bot added A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Aug 29, 2025
Copy link
Member Author

Sysix commented Aug 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review August 29, 2025 15:50
Copilot AI review requested due to automatic review settings August 29, 2025 15:50
@Sysix Sysix requested a review from camc314 as a code owner August 29, 2025 15:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a feature flag condition to restrict test execution in the TSGoLint module. The change ensures that from_tsgo_lint_diagnostic tests only run when the language_server feature is enabled, following up on previous work in PR #13374.

Key changes:

  • Added conditional compilation flag for language server feature to test module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
Copy link
Member Author

Sysix commented Aug 29, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-29-test_oxc_linter_run_from_tsgo_lint_diagnostic_tests_only_with_lsp_feature_flag branch from 93570e2 to 13470b2 Compare August 29, 2025 15:54
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 29, 2025

CodSpeed Instrumentation Performance Report

Merging #13396 will improve performances by 9.98%

Comparing 08-29-test_oxc_linter_run_from_tsgo_lint_diagnostic_tests_only_with_lsp_feature_flag (13470b2) with main (c215619)1

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.7 ms 3.4 ms +9.98%

Footnotes

  1. No successful run was found on main (13470b2) during the generation of this report, so c215619 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot merged commit 13470b2 into main Aug 29, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-29-test_oxc_linter_run_from_tsgo_lint_diagnostic_tests_only_with_lsp_feature_flag branch August 29, 2025 15:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant