test(transformer/styled-components): fix test case#13377
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 29, 2025
Merged
test(transformer/styled-components): fix test case#13377graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-transformer
This was referenced Aug 29, 2025
Merged
refactor(transformer/styled-components): clarify whitespace removal logic in CSS minification
#13375
Merged
Member
Author
overlookmotel
force-pushed
the
08-29-test_transformer_styled-components_fix_test_case
branch
from
b02d63c to
35e04d5
Compare
overlookmotel
force-pushed
the
08-29-fix_transformer_styled-components_remove_trailing_whitespace_in_css_minification
branch
2 times, most recently
from
857ab3b to
68001f8
Compare
overlookmotel
force-pushed
the
08-29-test_transformer_styled-components_fix_test_case
branch
from
35e04d5 to
3f13232
Compare
Member
Merge activity
|
Fix a test case which was previously failing. The original test case in `babel-plugin-styled-components` *does* include a space before `height:`. Our copy of the test had got changed somehow (wrongly). This PR brings the case back into alignment with the original and, thanks to #13346, it now passes. https://github.com/styled-components/babel-plugin-styled-components/blob/4e2eb388d9c90f2921c306c760657d059d01a518/test/fixtures/minify-single-line-comments-with-interpolations/output.js#L26-L29
graphite-app
bot
force-pushed
the
08-29-fix_transformer_styled-components_remove_trailing_whitespace_in_css_minification
branch
from
68001f8 to
1fca9b8
Compare
graphite-app
bot
force-pushed
the
08-29-test_transformer_styled-components_fix_test_case
branch
from
3f13232 to
f02b05e
Compare
Base automatically changed from
08-29-fix_transformer_styled-components_remove_trailing_whitespace_in_css_minification
to
main
August 29, 2025 03:23
graphite-app
bot
deleted the
08-29-test_transformer_styled-components_fix_test_case
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a test case which was previously failing. The original test case in
babel-plugin-styled-componentsdoes include a space beforeheight:. Our copy of the test had got changed somehow (wrongly). This PR brings the case back into alignment with the original and, thanks to #13346, it now passes.https://github.com/styled-components/babel-plugin-styled-components/blob/4e2eb388d9c90f2921c306c760657d059d01a518/test/fixtures/minify-single-line-comments-with-interpolations/output.js#L26-L29