feat(parser): report more invalid modifier locations

[ulrichstark]

Changes

• Added all 22 examples of Forbid invalid modifiers #11713 to tasks/coverage/misc/fail
• Added Default and Export to modifiers
• Added three new TS diagnostics: 1029, 1031, and 1070
• Split off FunctionKind::Constructor from FunctionKind::ClassMethod to differentiate when verifying modifiers of formal parameter
• Added multiple checks to verify modifiers

Results

• "Negative Passed" percentage of parser_babel.snap and parser_typescript.snap increased
• Better diagnostic messages in both snapshots
• All new failing examples of original issue do really fail
• Closes Forbid invalid modifiers #11713

[Copilot]

Pull Request Overview

This PR enhances the TypeScript parser to better validate modifier locations and report more specific diagnostic errors when modifiers are used incorrectly. The changes implement stricter checks for where modifiers can be placed in TypeScript code.

• Added support for tracking Default and Export modifiers in the modifier system
• Introduced new TypeScript diagnostic error codes (1029, 1031, 1070) for invalid modifier usage
• Split constructor functions from class methods to enable more precise modifier validation

Reviewed Changes

Copilot reviewed 7 out of 32 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/oxc_parser/src/modifiers.rs	Added Default and Export modifier variants with validation logic
crates/oxc_parser/src/lexer/kind.rs	Extended modifier detection to include Default and Export tokens
crates/oxc_parser/src/js/mod.rs	Added Constructor as a distinct function kind
crates/oxc_parser/src/js/function.rs	Updated parameter modifier validation with constructor-specific rules
crates/oxc_parser/src/js/class.rs	Added modifier validation for class elements and updated constructor parsing
crates/oxc_parser/src/ts/statement.rs	Added modifier validation for type members
crates/oxc_parser/src/diagnostics.rs	Added three new TypeScript diagnostic error functions

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13368 will not alter performance

_{Comparing ulrichstark:report-invalid-modifiers (a4b8707) with main (72468f9)}

Summary

✅ 38 untouched benchmarks

[ulrichstark]

I'm unsure about the failing allocations CI check... I did run the command locally, committed my changes but it still failed. Just reset back and force pushed to remove the attempt of making this CI check happy.

[graphite-app]

Merge activity

• Aug 29, 2:59 AM UTC: @ulrichstark we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

[Boshen]

Great work!