Skip to content

Comments

test(language_server): dont run tsgolint related test on big-edian#13342

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-28-test_language_server_dont_run_tsgolint_related_test_on_big-edian
Aug 27, 2025
Merged

test(language_server): dont run tsgolint related test on big-edian#13342
graphite-app[bot] merged 1 commit intomainfrom
08-28-test_language_server_dont_run_tsgolint_related_test_on_big-edian

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Aug 27, 2025

No description provided.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Aug 27, 2025
Copy link
Member Author

Sysix commented Aug 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review August 27, 2025 22:24
@Sysix Sysix requested a review from camc314 as a code owner August 27, 2025 22:24
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 27, 2025

CodSpeed Instrumentation Performance Report

Merging #13342 will not alter performance

Comparing 08-28-test_language_server_dont_run_tsgolint_related_test_on_big-edian (33e0e8b) with main (53de36e)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (33e0e8b) during the generation of this report, so 53de36e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
Copy link
Contributor

camc314 commented Aug 27, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-28-test_language_server_dont_run_tsgolint_related_test_on_big-edian branch from fd8d42a to 33e0e8b Compare August 27, 2025 22:42
@graphite-app graphite-app bot merged commit 33e0e8b into main Aug 27, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-28-test_language_server_dont_run_tsgolint_related_test_on_big-edian branch August 27, 2025 22:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
@overlookmotel
Copy link
Member

It looks to me like the big-endian tests only fail because the cross environment doesn't include NodeJS, pnpm etc. Ideally, rather than skipping these tests, we'd prep the environment so they can run successfully. (how to do that I don't know!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants