Skip to content

Comments

refactor(linter): ContextSubHost hold owned Semantic#13338

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-27-refactor_linter_contextsubhost_hold_owned_semantic_
Aug 27, 2025
Merged

refactor(linter): ContextSubHost hold owned Semantic#13338
graphite-app[bot] merged 1 commit intomainfrom
08-27-refactor_linter_contextsubhost_hold_owned_semantic_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 27, 2025

ContextSubHost does not share Semantic with any other structure, so Rc<Semantic> is unnecessary overhead. Make it contain owned Semantic instead.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 27, 2025
Copy link
Member Author

overlookmotel commented Aug 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 27, 2025

CodSpeed Instrumentation Performance Report

Merging #13338 will not alter performance

Comparing 08-27-refactor_linter_contextsubhost_hold_owned_semantic_ (53de36e) with main (d787517)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (53de36e) during the generation of this report, so d787517 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot force-pushed the 08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_ branch from cb2a00e to 420921a Compare August 27, 2025 21:48
@graphite-app graphite-app bot requested a review from Dunqing as a code owner August 27, 2025 21:48
@graphite-app graphite-app bot force-pushed the 08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_ branch from 420921a to cfcbe76 Compare August 27, 2025 21:48
@graphite-app graphite-app bot force-pushed the 08-27-refactor_linter_contextsubhost_hold_owned_semantic_ branch from 83393ba to 218f2f0 Compare August 27, 2025 21:49
@graphite-app graphite-app bot changed the base branch from 08-27-refactor_semantic_store_comments_as_a_slice_instead_of_vec_ to graphite-base/13338 August 27, 2025 22:28
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
Copy link
Member Author

overlookmotel commented Aug 27, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/13338 to main August 27, 2025 22:33
@github-actions github-actions bot added the A-semantic Area - Semantic label Aug 27, 2025
`ContextSubHost` does not share `Semantic` with any other structure, so `Rc<Semantic>` is unnecessary overhead. Make it contain owned `Semantic` instead.
@graphite-app graphite-app bot force-pushed the 08-27-refactor_linter_contextsubhost_hold_owned_semantic_ branch from 218f2f0 to 53de36e Compare August 27, 2025 22:34
@graphite-app graphite-app bot merged commit 53de36e into main Aug 27, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-27-refactor_linter_contextsubhost_hold_owned_semantic_ branch August 27, 2025 22:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants