fix(semantic): flag super in function inside ObjectExpression

[overlookmotel]

Fix #13323.

Make semantic raise errors for the following illegal super uses:

o = {
  foo: function() {
    super.foo;
  },

  bar() {
    return function() {
      super.bar;
    };
  },

  [ function() { super.qux; } ]() {},

  get [ function() { super.bing; } ]() {},

  set [ function() { super.bong; } ](v) {},
};

[overlookmotel]

• fix(semantic): flag super in function inside ObjectExpression #13325 👈 (View in Graphite)
• refactor(semantic): clarify logic when checking super #13324
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13325 will improve performances by 13.33%

_{Comparing 08-27-fix_semantic_flag_super_in_function_inside_objectexpression_ (fd3233c) with main (84a584c)¹}

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	mangler[cal.com.tsx]	3.8 ms	3.4 ms	+13.33%

Footnotes

1. No successful run was found on main (fd3233c) during the generation of this report, so 84a584c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Dunqing]

Merge activity

• Aug 29, 9:49 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 29, 9:49 AM UTC: Dunqing added this pull request to the Graphite merge queue.
• Aug 29, 9:50 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
• Aug 29, 12:00 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 29, 12:00 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
• Aug 29, 12:00 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
• Aug 29, 12:00 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 29, 12:52 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
• Aug 29, 12:52 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 29, 1:05 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
• Aug 29, 1:10 PM UTC: Boshen added this pull request to the Graphite merge queue.
• Aug 29, 1:15 PM UTC: Merged by the Graphite merge queue.

[overlookmotel]

Graphite got confused. Have manually rebased on main. It should merge now.