Skip to content

Comments

fix(ast_visit): correct and expand comments in Utf8ToUtf16Converter#13310

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-26-fix_ast_visit_correct_and_expand_comments_in_utf8toutf16converter_
Aug 26, 2025
Merged

fix(ast_visit): correct and expand comments in Utf8ToUtf16Converter#13310
graphite-app[bot] merged 1 commit intomainfrom
08-26-fix_ast_visit_correct_and_expand_comments_in_utf8toutf16converter_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 26, 2025

Fix one inaccurate comment, fix typos, and add a comment about why arithmetic overflow is impossible.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Aug 26, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 26, 2025

CodSpeed Instrumentation Performance Report

Merging #13310 will not alter performance

Comparing 08-26-fix_ast_visit_correct_and_expand_comments_in_utf8toutf16converter_ (1cdc420) with main (45e0cd9)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (1cdc420) during the generation of this report, so 45e0cd9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review August 26, 2025 10:01
Copilot AI review requested due to automatic review settings August 26, 2025 10:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes and improves comments in the Utf8ToUtf16Converter module by correcting inaccurate documentation, fixing typos, and adding explanatory comments about overflow safety.

  • Fixed an inaccurate comment about partition_point behavior
  • Corrected spelling errors in variable names within comments
  • Added a comment explaining why arithmetic overflow is impossible in the context

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel
Copy link
Member Author

Only affects comments, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 26, 2025
Copy link
Member Author

overlookmotel commented Aug 26, 2025

Merge activity

…#13310)

Fix one inaccurate comment, fix typos, and add a comment about why arithmetic overflow is impossible.
@graphite-app graphite-app bot force-pushed the 08-26-fix_ast_visit_correct_and_expand_comments_in_utf8toutf16converter_ branch from 18411e3 to 1cdc420 Compare August 26, 2025 10:07
@graphite-app graphite-app bot merged commit 1cdc420 into main Aug 26, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-26-fix_ast_visit_correct_and_expand_comments_in_utf8toutf16converter_ branch August 26, 2025 10:12
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant