Skip to content

Comments

perf(linter): filter out rules which have no relevant node types in file#13297

Closed
camchenry wants to merge 1 commit into08-25-perf_linter_generate_node_type_info_for_lint_rules_with_let.else_from
08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file
Closed

perf(linter): filter out rules which have no relevant node types in file#13297
camchenry wants to merge 1 commit into08-25-perf_linter_generate_node_type_info_for_lint_rules_with_let.else_from
08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file

Conversation

@camchenry
Copy link
Member

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Aug 25, 2025
Copy link
Member Author

camchenry commented Aug 25, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 25, 2025

CodSpeed Instrumentation Performance Report

Merging #13297 will improve performances by 13.52%

Comparing 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file (34aaba9) with 08-25-perf_linter_generate_node_type_info_for_lint_rules_with_let.else_ (918b957)

Summary

⚡ 3 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
linter[RadixUIAdoptionSection.jsx] 1.5 ms 1.3 ms +13.52%
linter[binder.ts] 87.4 ms 83.3 ms +4.88%
linter[react.development.js] 32.6 ms 31.1 ms +4.91%

@camchenry camchenry force-pushed the 08-25-perf_linter_generate_node_type_info_for_lint_rules_with_let.else_ branch from ce94493 to e673f22 Compare August 25, 2025 20:36
@camchenry camchenry force-pushed the 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file branch 2 times, most recently from 4fe7bb5 to b4803c4 Compare August 25, 2025 21:38
@camchenry camchenry changed the base branch from 08-25-perf_linter_generate_node_type_info_for_lint_rules_with_let.else_ to graphite-base/13297 August 26, 2025 01:34
@camchenry camchenry force-pushed the graphite-base/13297 branch from e673f22 to 8b57262 Compare August 26, 2025 01:46
@camchenry camchenry force-pushed the 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file branch from b4803c4 to e0279a2 Compare August 26, 2025 01:46
@camchenry camchenry force-pushed the graphite-base/13297 branch from 8b57262 to 13af599 Compare August 26, 2025 02:47
@camchenry camchenry force-pushed the 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file branch from e0279a2 to 2381b5b Compare August 26, 2025 02:47
@camchenry camchenry force-pushed the graphite-base/13297 branch from 13af599 to b272bd6 Compare August 26, 2025 02:51
@camchenry camchenry force-pushed the 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file branch from 2381b5b to 22f771e Compare August 26, 2025 02:51
@camchenry camchenry changed the base branch from graphite-base/13297 to 08-25-perf_linter_generate_node_type_info_for_lint_rules_with_let.else_ August 26, 2025 02:51
@camchenry camchenry changed the base branch from 08-25-perf_linter_generate_node_type_info_for_lint_rules_with_let.else_ to graphite-base/13297 August 26, 2025 02:52
@camchenry camchenry force-pushed the graphite-base/13297 branch from b272bd6 to 918b957 Compare August 26, 2025 02:53
@camchenry camchenry force-pushed the 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file branch from 22f771e to 34aaba9 Compare August 26, 2025 02:53
@camchenry camchenry changed the base branch from graphite-base/13297 to 08-25-perf_linter_generate_node_type_info_for_lint_rules_with_let.else_ August 26, 2025 02:53
@camchenry camchenry closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant