Skip to content

feat(minifier): add --max-iterations for debugging#13291

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-25-feat_minifier_add_--max-iterations_for_debugging
Aug 25, 2025
Merged

feat(minifier): add --max-iterations for debugging#13291
graphite-app[bot] merged 1 commit intomainfrom
08-25-feat_minifier_add_--max-iterations_for_debugging

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 25, 2025

Added --max-iterations to make it easier to debug what has changed in each iteration.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Aug 25, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red force-pushed the 08-25-feat_minifier_add_--max-iterations_for_debugging branch from ac1aeae to 52941cf Compare August 25, 2025 13:42
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 25, 2025

CodSpeed Instrumentation Performance Report

Merging #13291 will not alter performance

Comparing 08-25-feat_minifier_add_--max-iterations_for_debugging (593f54c) with main (87e68b5)

Summary

✅ 34 untouched benchmarks

@sapphi-red sapphi-red marked this pull request as ready for review August 25, 2025 13:49
Copilot AI review requested due to automatic review settings August 25, 2025 13:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 25, 2025
Copy link
Member

Boshen commented Aug 25, 2025

Merge activity

Added `--max-iterations` to make it easier to debug what has changed in each iteration.
@graphite-app graphite-app bot force-pushed the 08-25-feat_minifier_add_--max-iterations_for_debugging branch from 52941cf to 593f54c Compare August 25, 2025 14:47
@graphite-app graphite-app bot merged commit 593f54c into main Aug 25, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-25-feat_minifier_add_--max-iterations_for_debugging branch August 25, 2025 14:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants