feat(minifier): merge assignments in sequence exprs to variable declaration#13270
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 24, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-minifier
CodSpeed Instrumentation Performance ReportMerging #13270 will not alter performanceComparing Summary
Footnotes
|
sapphi-red
force-pushed
the
08-23-feat_minifier_merge_assignments_in_sequence_exprs_to_variable_declaration
branch
from
2ada070 to
d75eb97
Compare
sapphi-red
force-pushed
the
08-23-feat_minifier_merge_assignment_to_variable_declaration
branch
2 times, most recently
from
92300a2 to
f288210
Compare
sapphi-red
force-pushed
the
08-23-feat_minifier_merge_assignments_in_sequence_exprs_to_variable_declaration
branch
from
d75eb97 to
992af91
Compare
Member
Merge activity
|
…ration (#13270) Compress `var a, b; a = 0, b = 1` into `var a = 0, b = 1`.
graphite-app
bot
force-pushed
the
08-23-feat_minifier_merge_assignment_to_variable_declaration
branch
from
f288210 to
a19e84f
Compare
graphite-app
bot
force-pushed
the
08-23-feat_minifier_merge_assignments_in_sequence_exprs_to_variable_declaration
branch
from
992af91 to
a08dd5a
Compare
Base automatically changed from
08-23-feat_minifier_merge_assignment_to_variable_declaration
to
main
August 24, 2025 10:54
graphite-app
bot
deleted the
08-23-feat_minifier_merge_assignments_in_sequence_exprs_to_variable_declaration
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
…TDZ error would be introduced (#13635) ```js let x; x = (() => x?.a)(); ``` should not be transformed to ```js let x = (() => x?.a)(); ``` , as it would introduce a TDZ error. To fix that, I limited the right hand side of the assignment to be a literal value for let declarations. The precise check would be to check whether the right hand side includes a reference to the variable declared on the left hand side, but I didn't do that for now as it is complicated. If we implement that, we can improve this condition too. https://github.com/oxc-project/oxc/blob/5d597f71c06a9c56fe404a712c05b61e2da3697a/crates/oxc_minifier/src/peephole/minimize_statements.rs#L544-L548 fixes #13615 refs #13270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compress
var a, b; a = 0, b = 1intovar a = 0, b = 1.