Skip to content

feat(napi/oxlint): run JS plugins on multiple threads#13244

Closed
overlookmotel wants to merge 1 commit into08-14-feat_allocator_store_worker_thread_flags_in_fixedsizeallocator_from
08-19-feat_napi_oxlint_run_js_plugins_on_multiple_threads
Closed

feat(napi/oxlint): run JS plugins on multiple threads#13244
overlookmotel wants to merge 1 commit into08-14-feat_allocator_store_worker_thread_flags_in_fixedsizeallocator_from
08-19-feat_napi_oxlint_run_js_plugins_on_multiple_threads

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 20, 2025

Run JS linter plugins on multiple threads.

WIP. Seems to work - rules are run on JS worker threads in parallel - but effect on performance is not good. In best cases, improvement in perf is not large, and in some cases it's slower than running all JS rules on main thread.

This contrasts steeply against previous multi-threading prototype, where performance scaled well with number of cores. I need to investigate where the bottleneck is.

Copy link
Member Author

overlookmotel commented Aug 20, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 08-19-feat_napi_oxlint_run_js_plugins_on_multiple_threads branch from 626219f to bea9ec9 Compare August 20, 2025 23:04
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 20, 2025

CodSpeed Instrumentation Performance Report

Merging #13244 will not alter performance

Comparing 08-19-feat_napi_oxlint_run_js_plugins_on_multiple_threads (3ac3b7a) with 08-14-feat_allocator_store_worker_thread_flags_in_fixedsizeallocator_ (317698d)

Summary

✅ 34 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 08-19-feat_napi_oxlint_run_js_plugins_on_multiple_threads branch from bea9ec9 to 3ac3b7a Compare August 20, 2025 23:22
@overlookmotel overlookmotel self-assigned this Sep 10, 2025
@overlookmotel overlookmotel removed the request for review from camc314 September 10, 2025 09:33
@Boshen
Copy link
Member

Boshen commented Jan 21, 2026

Close as stale.

@Boshen Boshen closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants