fix(linter/prefer-for-of): false positive with diff member expression

[camc314]

fixes #13200

[camc314]

• fix(linter/prefer-for-of): false positive with diff member expression #13201 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR fixes a false positive in the prefer-for-of linter rule where it incorrectly flagged for-loops that access different objects with similar member expression patterns. The fix improves the comparison logic to accurately determine if the same array is being accessed in both the loop condition and body.

• Enhanced expression comparison to use is_same_expression utility instead of simple string matching
• Modified the rule to track both array name and expression for more accurate analysis
• Added comprehensive test cases for deeply nested object access patterns

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/rules/typescript/prefer_for_of.rs	Enhanced the core logic to properly compare member expressions using AST-based comparison instead of string matching
crates/oxc_linter/src/snapshots/typescript_prefer_for_of.snap	Added snapshot test outputs for new test cases involving deeply nested object access

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13201 will not alter performance

_{Comparing c/08-18-fix_linter_prefer-for-of_false_positive_with_diff_member_expression (163dbea) with main (76a9865)¹}

Summary

✅ 34 untouched benchmarks

Footnotes

1. No successful run was found on main (163dbea) during the generation of this report, so 76a9865 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[camc314]

Merge activity

• Aug 19, 4:47 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 19, 4:47 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Aug 19, 4:52 PM UTC: Merged by the Graphite merge queue.