Skip to content

refactor(linter): store source_text of already opened files for TsGoLintState #13197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 18, 2025
Merged

refactor(linter): store source_text of already opened files for TsGoLintState #13197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions crates/oxc_linter/src/tsgolint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ impl TsGoLintState {
let mut buffer = Vec::with_capacity(8192);
let mut read_buf = [0u8; 8192];

let mut source_text_map: FxHashMap<PathBuf, String> = FxHashMap::default();

loop {
match stdout.read(&mut read_buf) {
Ok(0) => break, // EOF
Expand Down Expand Up @@ -145,11 +147,23 @@ impl TsGoLintState {
},
);

let source_text: &str =
if let Some(source_text) = source_text_map.get(&path) {
source_text.as_str()
} else {
let source_text = read_to_string(&path)
.unwrap_or_else(|_| String::new());
// Insert and get a reference to the inserted string
let entry = source_text_map
.entry(path.clone())
.or_insert(source_text);
entry.as_str()
};

let diagnostics = DiagnosticService::wrap_diagnostics(
cwd_clone.clone(),
path.clone(),
&read_to_string(&path)
.unwrap_or_else(|_| String::new()),
source_text,
vec![oxc_diagnostic],
);

Expand Down
Loading