Skip to content

fix(oxlint)!: do not ignore hidden dot directories by default#13194

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-18-fix_oxlint_do_not_ignore_files_inside_directories_with_a_starting_dot
Aug 19, 2025
Merged

fix(oxlint)!: do not ignore hidden dot directories by default#13194
graphite-app[bot] merged 1 commit intomainfrom
08-18-fix_oxlint_do_not_ignore_files_inside_directories_with_a_starting_dot

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Aug 18, 2025

closes #13183
Or should we introduce a new CLI flag?

@github-actions github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Aug 18, 2025
Copy link
Member Author

Sysix commented Aug 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review August 18, 2025 16:49
Copilot AI review requested due to automatic review settings August 18, 2025 16:49
@Sysix Sysix requested a review from camc314 as a code owner August 18, 2025 16:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where oxlint was ignoring files inside directories that start with a dot (hidden directories). The fix ensures that files within dot directories are now properly linted by setting the hidden(false) option in the file walker configuration.

  • Modified the walker configuration to include files in hidden directories
  • Added a test case to verify the fix works correctly
  • Created test fixtures to demonstrate linting of files in dot directories

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
apps/oxlint/src/walk.rs Added hidden(false) to the walker configuration to include files in dot directories
apps/oxlint/src/lint.rs Added test case for dot folder functionality
apps/oxlint/src/snapshots/fixtures__dot_folder_@oxlint.snap Test snapshot showing expected output when linting files in dot directories
apps/oxlint/fixtures/dot_folder/.a_dot_folder/index.ts Test fixture file in a dot directory containing a debugger statement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would prefer not, but this technically a breaking change so 🤷

@camc314 camc314 requested a review from Boshen August 18, 2025 16:51
@Boshen Boshen changed the title fix(oxlint): do not ignore files inside directories with a starting dot fix(oxlint)!: do not ignore hidden dot directories by default Aug 19, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 19, 2025
Copy link
Member

Boshen commented Aug 19, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-18-fix_oxlint_do_not_ignore_files_inside_directories_with_a_starting_dot branch from 3723180 to 63abd7c Compare August 19, 2025 00:39
@graphite-app graphite-app bot merged commit 63abd7c into main Aug 19, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 08-18-fix_oxlint_do_not_ignore_files_inside_directories_with_a_starting_dot branch August 19, 2025 00:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 19, 2025
This was referenced Aug 26, 2025
@eMerzh
Copy link

eMerzh commented Aug 26, 2025

Is it possible that this has lead to oxlint linting the git directories? which is probably not ideal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: lint hidden dot folder

5 participants