fix(oxlint)!: do not ignore hidden dot directories by default#13194
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where oxlint was ignoring files inside directories that start with a dot (hidden directories). The fix ensures that files within dot directories are now properly linted by setting the hidden(false) option in the file walker configuration.
- Modified the walker configuration to include files in hidden directories
- Added a test case to verify the fix works correctly
- Created test fixtures to demonstrate linting of files in dot directories
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/src/walk.rs | Added hidden(false) to the walker configuration to include files in dot directories |
| apps/oxlint/src/lint.rs | Added test case for dot folder functionality |
| apps/oxlint/src/snapshots/fixtures__dot_folder_@oxlint.snap | Test snapshot showing expected output when linting files in dot directories |
| apps/oxlint/fixtures/dot_folder/.a_dot_folder/index.ts | Test fixture file in a dot directory containing a debugger statement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
camc314
left a comment
There was a problem hiding this comment.
i would prefer not, but this technically a breaking change so 🤷
Merge activity
|
closes #13183 Or should we introduce a new CLI flag?
3723180 to
63abd7c
Compare
|
Is it possible that this has lead to oxlint linting the git directories? which is probably not ideal |

closes #13183
Or should we introduce a new CLI flag?