Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables oxlint for the entire monorepo by adding a centralized configuration and updating package dependencies. The changes consolidate linting configuration from individual workspace packages to a monorepo-wide approach.
- Adds a global oxlint configuration file with comprehensive plugin support
- Updates oxlint dependency version and adds a new lint script to the root package.json
- Removes oxlint dependency from the VSCode editor package and consolidates its configuration
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds lint script and updates oxlint dependencies for monorepo-wide linting |
| editors/vscode/package.json | Removes oxlint dependency and updates TypeScript to use catalog reference |
| editors/vscode/client/ConfigService.ts | Adds void operator to silence unused return value warning |
| editors/vscode/.oxlintrc.json | Removes local oxlint configuration file |
| .oxlintrc.json | Adds comprehensive monorepo-wide oxlint configuration with plugins and ignore patterns |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Boshen
force-pushed
the
oxlint
branch
2 times, most recently
from
ea8f58f to
99bc1b1
Compare
Boshen
changed the title
This was referenced Aug 18, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 18, 2025
Same as #13184. #13173 enabled Oxlint for all the repo, but we currently skip `napi` directory. Fix all errors that Oxlint flags in `napi/parser`. We currently can't turn on Oxlint for the directory, because `oxlint-disable` comments don't work for type-aware rules, but we should be able to once that's fixed.
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
#13173 enabled Oxlint for all the repo, but we currently skip `napi` directory. Fix all errors that Oxlint flags in `napi/oxlint2`. We currently can't turn on Oxlint for the directory, because `oxlint-disable` comments don't work for type-aware rules, but we should be able to once that's fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also enabled
--type-aware.