refactor(napi/oxlint): move creating JS buffer into separate function#13133
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 16, 2025
Conversation
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts buffer creation logic into a separate function to prepare for future multi-threading support for JS plugins. The refactoring moves the complex buffer management code that handles allocator metadata and JS buffer transfer into its own dedicated function.
- Extracted buffer creation and metadata handling into a new
get_bufferfunction - Moved detailed documentation about buffer lifecycle management to the new function
- Maintained the same functionality while improving code organization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
camc314
approved these changes
Aug 16, 2025
Contributor
Merge activity
|
…#13133) Refactor only. Move block of code for creating a JS buffer out into its own function. This code is going to get more complicated to accommodate JS plugins on multiple threads.
graphite-app
bot
force-pushed
the
08-15-refactor_napi_parser_move_creating_js_buffer_into_separate_function
branch
from
3a1001c to
c8b97de
Compare
graphite-app
bot
deleted the
08-15-refactor_napi_parser_move_creating_js_buffer_into_separate_function
branch
overlookmotel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor only. Move block of code for creating a JS buffer out into its own function. This code is going to get more complicated to accommodate JS plugins on multiple threads.