Skip to content

fix(linter): preserve json key order for oxlint --init#13121

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-15-fix_linter_preserve_json_key_order_for_oxlint_--init_
Aug 15, 2025
Merged

fix(linter): preserve json key order for oxlint --init#13121
graphite-app[bot] merged 1 commit intomainfrom
08-15-fix_linter_preserve_json_key_order_for_oxlint_--init_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 15, 2025

closes #13111

Copilot AI review requested due to automatic review settings August 15, 2025 14:50
@Boshen Boshen requested a review from camc314 as a code owner August 15, 2025 14:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a configuration output issue by preserving JSON key order when using the oxlint --init command. The change ensures that generated configuration files have consistent, ordered keys rather than random ordering.

Key Changes

  • Enable the preserve_order feature for the serde_json dependency to maintain deterministic JSON key ordering

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the A-linter Area - Linter label Aug 15, 2025
Copy link
Member Author

Boshen commented Aug 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Aug 15, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Copy link
Contributor

camc314 commented Aug 15, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-15-fix_linter_preserve_json_key_order_for_oxlint_--init_ branch from 27e6683 to 81b0162 Compare August 15, 2025 15:02
@graphite-app graphite-app bot merged commit 81b0162 into main Aug 15, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 08-15-fix_linter_preserve_json_key_order_for_oxlint_--init_ branch August 15, 2025 15:05
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: sort the rules in oxlint --init

3 participants