refactor(linter): move TsGoLintInput creation into own function#13118
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 15, 2025
Merged
Conversation
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This refactor moves the creation of TsGoLintInput from inline code into a dedicated method to improve code organization and prepare for future language server integration.
- Extracted inline
TsGoLintInputcreation logic into a separatejson_inputmethod - Updated documentation format from inline comment to proper doc comment with JSON example
- Added
#[inline]attribute to the new method for performance optimization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sysix
force-pushed
the
08-15-refactor_linter_move_tsgolintinput_creation_into_own_function
branch
from
b7c6756 to
7fcd4d6
Compare
Contributor
Merge activity
|
…3118) Move the creation into an own function. This would be later helpful when implementing it for the language server.
graphite-app
bot
force-pushed
the
08-15-refactor_linter_move_tsgolintinput_creation_into_own_function
branch
from
7fcd4d6 to
23e5642
Compare
graphite-app
bot
deleted the
08-15-refactor_linter_move_tsgolintinput_creation_into_own_function
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the creation into an own function.
This would be later helpful when implementing it for the language server.