fix(linter): fix whitespace handling in disable directives#13083
Merged
camc314 merged 1 commit intooxc-project:mainfrom Aug 14, 2025
Merged
Conversation
Contributor
lambda47
commented
Aug 14, 2025
lambda47
commented
- fixes(linter: Oxlint doesn't respect multiline eslint disable comments #13071)
- Replace ' ' with char::is_whitespace for better whitespace detection
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
CodSpeed Instrumentation Performance ReportMerging #13083 will not alter performanceComparing Summary
|
lambda47
force-pushed
the
fix/fix-linter-disable_directives-parse
branch
2 times, most recently
from
314b197 to
1bf8292
Compare
camc314
requested changes
Aug 14, 2025
Contributor
camc314
left a comment
camc314
left a comment
There was a problem hiding this comment.
can we add a test for this change please
Contributor
Author
|
Sure, sorry, i forget it. |
- fixes: oxc-project#13071 - Replace ' ' with char::is_whitespace for better whitespace detection
lambda47
force-pushed
the
fix/fix-linter-disable_directives-parse
branch
from
1bf8292 to
32be48b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.