refactor(semantic): implement Send and Sync for ScopingCell#13042
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 19, 2025
Merged
Conversation
github-actions
bot
added
A-semantic
This was referenced Aug 13, 2025
Member
Author
This was referenced Aug 13, 2025
CodSpeed Instrumentation Performance ReportMerging #13042 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
08-13-refactor_semantic_implement_send_and_sync_for_scopingcell_
branch
from
76d7ef7 to
94907c8
Compare
graphite-app
bot
force-pushed
the
08-12-fix_allocator_remove_unsound_send_impl_and_tighten_sync_requirements_for_vec_
branch
from
1529968 to
49299c7
Compare
graphite-app
bot
force-pushed
the
08-13-refactor_semantic_implement_send_and_sync_for_scopingcell_
branch
from
94907c8 to
b85beb1
Compare
aapoalas
reviewed
Aug 14, 2025
aapoalas
reviewed
Aug 14, 2025
This was referenced Jan 19, 2026
overlookmotel
changed the base branch from
08-12-fix_allocator_remove_unsound_send_impl_and_tighten_sync_requirements_for_vec_
to
graphite-base/13042
overlookmotel
force-pushed
the
08-13-refactor_semantic_implement_send_and_sync_for_scopingcell_
branch
from
b85beb1 to
fd22653
Compare
overlookmotel
force-pushed
the
graphite-base/13042
branch
from
49299c7 to
1b86fbb
Compare
overlookmotel
changed the base branch from
graphite-base/13042
to
08-18-fix_allocator_remove_unsound_send_impl_and_tighten_sync_requirement_for_hashmap_
overlookmotel
force-pushed
the
08-13-refactor_semantic_implement_send_and_sync_for_scopingcell_
branch
from
fd22653 to
32c7632
Compare
camc314
approved these changes
Aug 19, 2025
Contributor
Merge activity
|
…3042) Previous PRs removed unsound `Sync` impl for `Allocator` (#13033) and `Send` impl for `Vec` (#13041). Previously `ScopingCell` was `Send` and `Sync` (and therefore `Scoping` was too). The recent PRs mean that `ScopingCell` lost those traits too. This PR implements both traits again for `ScopingCell` by restricting its API slightly, so now it is `Send` and `Sync` again, but this time in a manner which maintains soundness. The comments in the code outline the logic of why I believe it to be sound. Rolldown relies on `ScopingCell` being `Send` and `Sync`. After this PR, this stack does not require any changes in Rolldown. I've checked that `cargo ck` in Rolldown passes when using the version of Oxc from this branch.
graphite-app
bot
force-pushed
the
08-18-fix_allocator_remove_unsound_send_impl_and_tighten_sync_requirement_for_hashmap_
branch
from
1b86fbb to
f490d27
Compare
graphite-app
bot
force-pushed
the
08-13-refactor_semantic_implement_send_and_sync_for_scopingcell_
branch
from
32c7632 to
cc067c2
Compare
Base automatically changed from
08-18-fix_allocator_remove_unsound_send_impl_and_tighten_sync_requirement_for_hashmap_
to
main
August 19, 2025 21:45
graphite-app
bot
deleted the
08-13-refactor_semantic_implement_send_and_sync_for_scopingcell_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PRs removed unsound
Syncimpl forAllocator(#13033) andSendimpl forVec(#13041).Previously
ScopingCellwasSendandSync(and thereforeScopingwas too). The recent PRs mean thatScopingCelllost those traits too.This PR implements both traits again for
ScopingCellby restricting its API slightly, so now it isSendandSyncagain, but this time in a manner which maintains soundness.The comments in the code outline the logic of why I believe it to be sound.
Rolldown relies on
ScopingCellbeingSendandSync. After this PR, this stack does not require any changes in Rolldown. I've checked thatcargo ckin Rolldown passes when using the version of Oxc from this branch.