feat(minifier): return total number of iterations for debugging#12995
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds debugging functionality to the minifier by tracking and returning the total number of iterations performed during the minification process. This information is displayed in the minsize benchmark output to help identify performance issues.
- Modifies the minifier API to return iteration count alongside the minified code
- Updates the benchmark table format to include an "Iterations" column
- Threads the iteration count through the minification pipeline from peephole optimizations to the final output
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/minsize/src/lib.rs | Updates minification functions to return iteration counts and modifies output table format |
| tasks/minsize/minsize.snap | Updates snapshot test to reflect new table format with iterations column |
| crates/oxc_minifier/src/peephole/mod.rs | Modifies run_in_loop to return the number of iterations performed |
| crates/oxc_minifier/src/lib.rs | Updates MinifierReturn struct to include iterations field and threads it through the build process |
| crates/oxc_minifier/src/compressor.rs | Updates build_with_scoping to return iteration count from peephole optimizations |
CodSpeed Instrumentation Performance ReportMerging #12995 will not alter performanceComparing Summary
|
Merge activity
|
3e71d2d to
7b9a781
Compare

No description provided.