Skip to content

refactor(ecmascript): change IsGlobalReference to GlobalContext#12952

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-10-refactor_ecmascript_change_isglobalreference_to_globalcontext_
Aug 10, 2025
Merged

refactor(ecmascript): change IsGlobalReference to GlobalContext#12952
graphite-app[bot] merged 1 commit intomainfrom
08-10-refactor_ecmascript_change_isglobalreference_to_globalcontext_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 10, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 10, 2025
Copy link
Member Author

Boshen commented Aug 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot changed the base branch from 08-10-feat_minifier_new_date_has_valuetype_object_ to graphite-base/12952 August 10, 2025 04:49
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 10, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/12952 to main August 10, 2025 04:54
@Boshen Boshen force-pushed the 08-10-refactor_ecmascript_change_isglobalreference_to_globalcontext_ branch from 06b1fef to df68d4a Compare August 10, 2025 06:12
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 10, 2025

CodSpeed Instrumentation Performance Report

Merging #12952 will not alter performance

Comparing 08-10-refactor_ecmascript_change_isglobalreference_to_globalcontext_ (0c5bffc) with main (53f7a9f)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (0c5bffc) during the generation of this report, so 53f7a9f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 10, 2025
@graphite-app graphite-app bot force-pushed the 08-10-refactor_ecmascript_change_isglobalreference_to_globalcontext_ branch from df68d4a to 0c5bffc Compare August 10, 2025 06:57
@graphite-app graphite-app bot merged commit 0c5bffc into main Aug 10, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 08-10-refactor_ecmascript_change_isglobalreference_to_globalcontext_ branch August 10, 2025 07:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 10, 2025
graphite-app bot pushed a commit that referenced this pull request Aug 10, 2025
#12952 renamed `IsGlobalReference` trait to `GlobalContext`. But we shouldn't rewrite history - the trait *was* called `IsGlobalReference`. Revert the changes to changelogs made in that PR.
This was referenced Aug 12, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025
…#12962)

oxc-project#12952 renamed `IsGlobalReference` trait to `GlobalContext`. But we shouldn't rewrite history - the trait *was* called `IsGlobalReference`. Revert the changes to changelogs made in that PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant