refactor(linter): allow marking rule as a tsgolint rule#12890
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12890 will not alter performanceComparing Summary
|
Boshen
requested changes
Aug 8, 2025
Member
Boshen
left a comment
Boshen
left a comment
There was a problem hiding this comment.
I'll amend some changes later today.
camchenry
force-pushed
the
08-07-refactor_linter_allow_marking_rule_as_tsgolint_rule
branch
from
9edc413 to
91a784e
Compare
Boshen
changed the base branch from
08-07-fix_linter_resolve_configured_rules_for_every_file_linted_by_tsgolint_
to
graphite-base/12890
Boshen
force-pushed
the
graphite-base/12890
branch
from
6eefea8 to
65e2112
Compare
Boshen
force-pushed
the
08-07-refactor_linter_allow_marking_rule_as_tsgolint_rule
branch
from
91a784e to
e21a5a0
Compare
Boshen
changed the title
Member
|
Decided not to change anything. |
Boshen
changed the title
Boshen
changed the title
Boshen
approved these changes
Aug 8, 2025
Boshen
deleted the
08-07-refactor_linter_allow_marking_rule_as_tsgolint_rule
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…12890) Making it easier to add new `tsgolint` rules, which will make this more favorable for implementing new rules with AI to speed up importing all the type-aware rules. Adds the ability to add a `(tsgolint)` marker in the `declare_oxc_lint!` macro which generates the necessary code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making it easier to add new
tsgolintrules, which will make this more favorable for implementing new rules with AI to speed up importing all the type-aware rules. Adds the ability to add a(tsgolint)marker in thedeclare_oxc_lint!macro which generates the necessary code.