Skip to content

fix(linter): react/jsx-curly-brace-presence report for JSXAttributeItem with padding space#12887

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-07-fix_linter_react_jsx-curly-brace-presence_report_for_jsxattributes_with_padding_space
Aug 8, 2025
Merged

fix(linter): react/jsx-curly-brace-presence report for JSXAttributeItem with padding space#12887
graphite-app[bot] merged 1 commit intomainfrom
08-07-fix_linter_react_jsx-curly-brace-presence_report_for_jsxattributes_with_padding_space

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Aug 7, 2025

This should be fixable, so report it too.

r#"<App prop={'foo'} attr={" foo "} />"#,
r#"<App prop="foo" attr=" foo " />"#,

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Aug 7, 2025
Copy link
Member Author

Sysix commented Aug 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review August 7, 2025 17:48
@Sysix Sysix requested a review from camc314 as a code owner August 7, 2025 17:48
@Sysix Sysix changed the title fix(linter): react/jsx-curly-brace-presence report for JSXAttributes with padding space fix(linter): react/jsx-curly-brace-presence report for JSXAttributeItem with padding space Aug 7, 2025
@Sysix Sysix marked this pull request as draft August 7, 2025 17:51
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 7, 2025

CodSpeed Instrumentation Performance Report

Merging #12887 will not alter performance

Comparing 08-07-fix_linter_react_jsx-curly-brace-presence_report_for_jsxattributes_with_padding_space (dac0f33) with main (238b183)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (dac0f33) during the generation of this report, so 238b183 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Sysix Sysix force-pushed the 08-07-fix_linter_react_jsx-curly-brace-presence_report_for_jsxattributes_with_padding_space branch from 1b0833b to fec9ae1 Compare August 7, 2025 17:53
@Sysix Sysix marked this pull request as ready for review August 7, 2025 17:53
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 8, 2025
Copy link
Contributor

camc314 commented Aug 8, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-07-fix_linter_react_jsx-curly-brace-presence_report_for_jsxattributes_with_padding_space branch from fec9ae1 to dac0f33 Compare August 8, 2025 10:26
@graphite-app graphite-app bot merged commit dac0f33 into main Aug 8, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 08-07-fix_linter_react_jsx-curly-brace-presence_report_for_jsxattributes_with_padding_space branch August 8, 2025 10:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants