refactor(linter): use fast-glob instead of globset for GlobSet

[shulaoda]

closes #12825

[shulaoda]

• refactor(linter): use fast-glob instead of globset for GlobSet #12870 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12870 will not alter performance

_{Comparing 08-07-refactor_linter_use_fast-glob_instead_of_globset_for_globset (238b183) with main (ed40581)¹}

Summary

✅ 34 untouched benchmarks

Footnotes

1. No successful run was found on main (238b183) during the generation of this report, so ed40581 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[camc314]

@shulaoda is there any risk to any changes to how patterns are matched, when switching from globset to fast-glob.

e.g. are there any cases where a pattern would previously match, but now does not match correctly (or the reverse)

[shulaoda]

@shulaoda is there any risk to any changes to how patterns are matched, when switching from globset to fast-glob.

e.g. are there any cases where a pattern would previously match, but now does not match correctly (or the reverse)

In general, the syntax of globset and fast-glob is nearly identical. However, for patterns like *.txt, globset automatically expands it to **/*.txt, matching both a.txt and path/a.txt, whereas fast-glob only matches the former.

[shulaoda]

Additionally, for patterns like */*.txt, globset will match files such as cc/s/foo.txt, while fast-glob only matches s/foo.txt.

[camc314]

Merge activity

• Aug 8, 10:18 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 8, 10:18 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Aug 8, 10:25 AM UTC: Merged by the Graphite merge queue.