Skip to content

refactor(estree): remove serializer for f32 #12838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 6, 2025
Merged

refactor(estree): remove serializer for f32 #12838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions crates/oxc_estree/src/serialize/primitives.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,6 @@ impl ESTree for bool {
}
}

/// [`ESTree`] implementation for `f32`.
impl ESTree for f32 {
fn serialize<S: Serializer>(&self, mut serializer: S) {
if self.is_finite() {
// For f32, we need custom formatting to match ryu_js behavior
let s = if *self == f32::MIN {
"-3.4028235e+38".to_string()
} else if *self == f32::MAX {
"3.4028235e+38".to_string()
} else {
// For other finite values, standard formatting works
format!("{self}")
};
serializer.buffer_mut().print_str(&s);
} else if self.is_nan() {
// Serialize `NAN` as `null`
// TODO: Throw an error? Use a sentinel value?
serializer.buffer_mut().print_str("null");
} else if *self == f32::INFINITY {
// Serialize `INFINITY` as `1e+400. `JSON.parse` deserializes this as `Infinity`.
serializer.buffer_mut().print_str("1e+400");
} else {
// Serialize `-INFINITY` as `-1e+400`. `JSON.parse` deserializes this as `-Infinity`.
serializer.buffer_mut().print_str("-1e+400");
}
}
}

/// [`ESTree`] implementation for `f64`.
impl ESTree for f64 {
fn serialize<S: Serializer>(&self, mut serializer: S) {
Expand Down Expand Up @@ -111,21 +83,6 @@ mod tests {
run_test(&[(true, "true"), (false, "false")]);
}

#[test]
fn serialize_f32() {
run_test(&[
(0.0, "0"),
(1.0, "1"),
(123_456.0, "123456"),
(0.12345, "0.12345"),
(123.45, "123.45"),
(f32::MIN, "-3.4028235e+38"),
(f32::MAX, "3.4028235e+38"),
(f32::INFINITY, "1e+400"),
(-f32::INFINITY, "-1e+400"),
]);
}

#[test]
fn serialize_f64() {
run_test(&[
Expand Down
Loading