Skip to content

feat(ast)!: remove IdentifierReference from qualifier field of TSImportType#12799

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_
Aug 5, 2025
Merged

feat(ast)!: remove IdentifierReference from qualifier field of TSImportType#12799
graphite-app[bot] merged 1 commit intomainfrom
c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Aug 4, 2025

closes #12042, #12797

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST A-codegen Area - Code Generation A-formatter Area - Formatter C-enhancement Category - New feature or request labels Aug 4, 2025
@camc314 camc314 marked this pull request as ready for review August 4, 2025 09:56
Copy link
Contributor Author

camc314 commented Aug 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch from 77abb0d to e1da626 Compare August 4, 2025 09:58
@camc314 camc314 marked this pull request as draft August 4, 2025 10:01
@camc314 camc314 force-pushed the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch from e1da626 to cf903e2 Compare August 4, 2025 10:04
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed Instrumentation Performance Report

Merging #12799 will not alter performance

Comparing c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ (50b91ac) with main (cacbd1e)

Summary

✅ 34 untouched benchmarks

@camc314 camc314 marked this pull request as ready for review August 4, 2025 10:07
@camc314 camc314 force-pushed the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch 2 times, most recently from c8f4709 to 8b59143 Compare August 4, 2025 10:38
@camc314 camc314 force-pushed the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch from 8b59143 to bcc9307 Compare August 4, 2025 11:03
@Boshen Boshen self-assigned this Aug 4, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 4, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Aug 4, 2025
@graphite-app graphite-app bot force-pushed the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch from bcc9307 to e069284 Compare August 4, 2025 16:57
@Sysix Sysix removed the 0-merge Merge with Graphite Merge Queue label Aug 4, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 5, 2025
@graphite-app graphite-app bot force-pushed the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch from e069284 to 50b91ac Compare August 5, 2025 05:55
@graphite-app graphite-app bot merged commit 50b91ac into main Aug 5, 2025
29 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 5, 2025
@graphite-app graphite-app bot deleted the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch August 5, 2025 06:01
This was referenced Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-codegen Area - Code Generation A-formatter Area - Formatter A-parser Area - Parser A-semantic Area - Semantic C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ast: the field qualifier of TSImportType shouldn't have a IdentifierReference

4 participants

Comments