Skip to content

fix(linter/import/extensions): update Default implementation for ExtensionsConfig #12783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 3, 2025
Merged

fix(linter/import/extensions): update Default implementation for ExtensionsConfig #12783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion crates/oxc_linter/src/rules/import/extensions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ impl FileExtensionConfig {
}
}

#[derive(Debug, Default, Clone)]
#[derive(Debug, Clone)]
pub struct ExtensionsConfig {
ignore_packages: bool,
require_extension: Option<FileExtensionConfig>,
Expand Down Expand Up @@ -88,6 +88,21 @@ impl ExtensionsConfig {
}
}

impl Default for ExtensionsConfig {
fn default() -> Self {
Self {
ignore_packages: true,
require_extension: None,
check_type_imports: false,
js: FileExtensionConfig::Never,
jsx: FileExtensionConfig::Never,
ts: FileExtensionConfig::Never,
tsx: FileExtensionConfig::Never,
json: FileExtensionConfig::Never,
}
}
}

#[derive(Debug, Default, Clone)]
pub struct Extensions(Box<ExtensionsConfig>);

Expand Down
1 change: 0 additions & 1 deletion crates/oxc_linter/tests/rule_configuration_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ fn test_rule_default_matches_from_configuration_null() {
// 1. The Default implementation returns the same values as from_configuration(null), or
// 2. The from_configuration method is updated to return Default::default() when given null
let exceptions = [
"import/extensions",
"import/no-anonymous-default-export",
"jest/no-deprecated-functions",
"jest/no-large-snapshots",
Expand Down
Loading