Skip to content

refactor(ecmascript): avoid redundant checks by splitting up match arms#12782

Merged
Boshen merged 1 commit intooxc-project:mainfrom
ulrichstark:avoid-redundant-checks-in-binary_operation_evaluate_value_to
Aug 5, 2025
Merged

refactor(ecmascript): avoid redundant checks by splitting up match arms#12782
Boshen merged 1 commit intooxc-project:mainfrom
ulrichstark:avoid-redundant-checks-in-binary_operation_evaluate_value_to

Conversation

@ulrichstark
Copy link
Contributor

Makes code a lot easier to understand and avoids some redundant checks in runtime.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Aug 3, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 3, 2025

CodSpeed Instrumentation Performance Report

Merging #12782 will not alter performance

Comparing ulrichstark:avoid-redundant-checks-in-binary_operation_evaluate_value_to (1be6f6c) with main (00bdfc0)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 5, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 5, 2025

Merge activity

  • Aug 5, 6:53 AM UTC: @ulrichstark we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@Boshen Boshen merged commit f3f6012 into oxc-project:main Aug 5, 2025
23 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 5, 2025
@ulrichstark ulrichstark deleted the avoid-redundant-checks-in-binary_operation_evaluate_value_to branch August 5, 2025 07:20
This was referenced Aug 6, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025
…ms (oxc-project#12782)

Makes code a lot easier to understand and avoids some redundant checks
in runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments