fix(transformer/class-properties): preserve computed keys if they may have side effects when remove_class_fields_without_initializer is enabled

[Dunqing]

When remove_class_fields_without_initializer is enabled, fields without initializers would be removed. However, if the key is computed, and it may have side effects, then we should extract it and place it before class, so that it can keep the same behavior as before.

Example:

Input:

import { Collection } from './collection.ts';

export class Obj {
  public readonly [Collection.identifier] = true;
  public readonly [Collection.identifier2];
  public static readonly [Collection.identifier3] = true;
  public static readonly  [Collection.identifier4];
}

Options:

{
  "assumptions": {
    "setPublicClassFields": true
  },
  "plugins": [
    "transform-class-properties",
    [
      "transform-typescript",
      {
        "removeClassFieldsWithoutInitializer": true
      }
    ]
  ]
}

Output:

import { Collection } from "./collection.ts";
let _Collection$identifie, _Collection$identifie2;
_Collection$identifie = Collection.identifier;
Collection.identifier2;
_Collection$identifie2 = Collection.identifier3;
Collection.identifier4;
export class Obj {
  constructor() {
    this[_Collection$identifie] = true;
  }
}
Obj[_Collection$identifie2] = true;

[Dunqing]

• fix(transformer/class-properties): preserve computed keys if they may have side effects when remove_class_fields_without_initializer is enabled #12772 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12772 will not alter performance

_{Comparing 08-03-fix_transformer_class-properties_preserve_computed_keys_if_they_may_have_side_effects_when_remove_class_fields_without_initializer_is_enabled (d02e17c) with main (701399e)}

Summary

✅ 21 untouched benchmarks
🆕 13 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	codegen[RadixUIAdoptionSection.jsx]	N/A	128.2 µs	N/A
🆕	codegen[binder.ts]	N/A	4.2 ms	N/A
🆕	codegen[cal.com.tsx]	N/A	37 ms	N/A
🆕	codegen[react.development.js]	N/A	2 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.5 ms	N/A
🆕	linter[binder.ts]	N/A	145.9 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[react.development.js]	N/A	52 ms	N/A
🆕	estree[checker.ts]	N/A	104.7 ms	N/A
🆕	parser[RadixUIAdoptionSection.jsx]	N/A	84.2 µs	N/A
🆕	parser[binder.ts]	N/A	3.3 ms	N/A
🆕	parser[cal.com.tsx]	N/A	26.8 ms	N/A
🆕	parser[react.development.js]	N/A	1.3 ms	N/A

[Boshen]

Merge activity

• Aug 3, 7:15 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 3, 7:15 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Aug 3, 7:23 AM UTC: Merged by the Graphite merge queue.