Skip to content

Comments

fix(transformer/typescript): remove properties with definite assignment assertion#12713

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-01-fix_transformer_remove_typescript_properties_with_definite_assignment_assertion
Aug 2, 2025
Merged

fix(transformer/typescript): remove properties with definite assignment assertion#12713
graphite-app[bot] merged 1 commit intomainfrom
08-01-fix_transformer_remove_typescript_properties_with_definite_assignment_assertion

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Aug 1, 2025

close: rolldown/tsdown#399

Here is a TypeScript Playground, which shows the expected output.

A Babel test failed because Babel's transforming behavior differs from TypeScript's. Additionally, ESBuild isn't the same.
See Babel Playground

@Dunqing Dunqing requested a review from overlookmotel as a code owner August 1, 2025 09:40
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Aug 1, 2025
Copy link
Member Author

Dunqing commented Aug 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 1, 2025

CodSpeed Instrumentation Performance Report

Merging #12713 will not alter performance

Comparing 08-01-fix_transformer_remove_typescript_properties_with_definite_assignment_assertion (0e1e79d) with main (c6bfb8a)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (2f255a0) during the generation of this report, so c6bfb8a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 1, 2025
Copy link
Member

Boshen commented Aug 1, 2025

Merge activity

@Boshen
Copy link
Member

Boshen commented Aug 1, 2025

@Dunqing panic!

@Dunqing Dunqing force-pushed the 08-01-fix_transformer_remove_typescript_properties_with_definite_assignment_assertion branch from 3c4b348 to f771ca7 Compare August 2, 2025 10:57
@Dunqing Dunqing removed the 0-merge Merge with Graphite Merge Queue label Aug 2, 2025
@graphite-app graphite-app bot force-pushed the 08-01-fix_transformer_remove_typescript_properties_with_definite_assignment_assertion branch from f771ca7 to 0e1e79d Compare August 2, 2025 11:12
@graphite-app graphite-app bot merged commit 0e1e79d into main Aug 2, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-01-fix_transformer_remove_typescript_properties_with_definite_assignment_assertion branch August 2, 2025 11:22
Copilot AI added a commit that referenced this pull request Aug 2, 2025
Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is an issue with the conversion of TypeScript Classes, which does not meet expectations and results in unexpected code running outcomes.

2 participants