Skip to content

Comments

perf(semantic): remove check for Program when iterating ancestors#12682

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-31-perf_semantic_remove_check_for_program_when_iterating_ancestors
Jul 31, 2025
Merged

perf(semantic): remove check for Program when iterating ancestors#12682
graphite-app[bot] merged 1 commit intomainfrom
07-31-perf_semantic_remove_check_for_program_when_iterating_ancestors

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 31, 2025

Tiny optimization. There's no need to check for AstKind::Program and break the loop, because the ancestors iterator already does this check.

@github-actions github-actions bot added A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance labels Jul 31, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 31, 2025 14:55
@overlookmotel overlookmotel requested a review from Dunqing as a code owner July 31, 2025 14:55
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 31, 2025

CodSpeed Instrumentation Performance Report

Merging #12682 will not alter performance

Comparing 07-31-perf_semantic_remove_check_for_program_when_iterating_ancestors (6564215) with main (da3a881)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (6564215) during the generation of this report, so da3a881 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 31, 2025
Copy link
Member

Boshen commented Jul 31, 2025

Merge activity

…12682)

Tiny optimization. There's no need to check for `AstKind::Program` and break the loop, because the ancestors iterator already does this check.
@graphite-app graphite-app bot force-pushed the 07-31-perf_semantic_remove_check_for_program_when_iterating_ancestors branch from c3756ed to 6564215 Compare July 31, 2025 15:23
@graphite-app graphite-app bot merged commit 6564215 into main Jul 31, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 07-31-perf_semantic_remove_check_for_program_when_iterating_ancestors branch July 31, 2025 15:31
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants