Skip to content

refactor(semantic)!: Scoping::get_resolved_reference_ids return slice #12665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 31, 2025
Merged

refactor(semantic)!: Scoping::get_resolved_reference_ids return slice #12665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_semantic/src/scoping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ impl Scoping {
///
/// If you want direct access to a symbol's [`Reference`]s, use [`Scoping::get_resolved_references`].
#[inline]
pub fn get_resolved_reference_ids(&self, symbol_id: SymbolId) -> &ArenaVec<'_, ReferenceId> {
pub fn get_resolved_reference_ids(&self, symbol_id: SymbolId) -> &[ReferenceId] {
&self.cell.borrow_dependent().resolved_references[symbol_id.index()]
}

Expand Down
2 changes: 1 addition & 1 deletion tasks/transform_checker/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ impl PostTransformChecker<'_, '_> {

// Check resolved references match
let reference_ids = self.get_pair(symbol_ids, |scoping, symbol_id| {
scoping.get_resolved_reference_ids(symbol_id).iter().copied().collect::<Vec<_>>()
scoping.get_resolved_reference_ids(symbol_id).to_vec()
});
if self.remap_reference_ids_sets(&reference_ids).is_mismatch() {
self.errors.push_mismatch(
Expand Down
Loading