refactor(semantic): ArrowFunctionExpression leave scope before leaving node

[overlookmotel]

Bring Visit::visit_arrow_function_expression in SemanticBuilder in line with walk_arrow_function_expression - leave scope before leaving node:

oxc/crates/oxc_ast_visit/src/generated/visit.rs

Lines 2490 to 2517 in fc4a327

	pub fn walk_arrow_function_expression<'a, V: Visit<'a>>(
	visitor: &mut V,
	it: &ArrowFunctionExpression<'a>,
	) {
	let kind = AstKind::ArrowFunctionExpression(visitor.alloc(it));
	visitor.enter_node(kind);
	visitor.enter_scope(
	{
	let mut flags = ScopeFlags::Function | ScopeFlags::Arrow;
	if it.has_use_strict_directive() {
	flags |= ScopeFlags::StrictMode;
	}
	flags
	},
	&it.scope_id,
	);
	visitor.visit_span(&it.span);
	if let Some(type_parameters) = &it.type_parameters {
	visitor.visit_ts_type_parameter_declaration(type_parameters);
	}
	visitor.visit_formal_parameters(&it.params);
	if let Some(return_type) = &it.return_type {
	visitor.visit_ts_type_annotation(return_type);
	}
	visitor.visit_function_body(&it.body);
	visitor.leave_scope();
	visitor.leave_node(kind);
	}

The order of calls makes no difference to logic in this case, but it's the only place where we had leave_scope and leave_node in opposite order in SemanticBuilder's visitor. It's better to be consistent.

[overlookmotel]

• refactor(semantic): ArrowFunctionExpression leave scope before leaving node #12659 👈 (View in Graphite)
• refactor(semantic): move comments #12658
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12659 will not alter performance

_{Comparing 07-31-refactor_semantic_arrowfunctionexpression_leave_scope_before_leaving_node (6a1c7c6) with main (d7a3e03)}

Summary

✅ 34 untouched benchmarks

[overlookmotel]

After other recent PRs, this PR now only moves 1 line. I'm going to merge without review.

[overlookmotel]

Merge activity

• Aug 1, 9:14 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 1, 9:14 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Aug 1, 9:22 PM UTC: Merged by the Graphite merge queue.