fix(isolated-declarations): optional parameter property misses undefined type

[Dunqing]

TypeScript Playground

Input:

export class PrivateConstructorWithOptionalParameters {
	private constructor(
		required: string,
		optional?: number,
		public publicOptional?: boolean,
		private privateOptional?: string,
		readonly readonlyOptional?: number,
	) {}
}

Output:

export declare class PrivateConstructorWithOptionalParameters {
    publicOptional?: boolean | undefined;
    private privateOptional?;
    readonly readonlyOptional?: number | undefined;
    private constructor();
}

optional parameter property should union the original type with undefined

[Dunqing]

• fix(isolated-declarations): optional parameter property misses undefined type #12579 👈 (View in Graphite)
• fix(isolated-declarations): crash when transforming a class with a parameter property in a private constructor #12578
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12579 will not alter performance

_{Comparing 07-28-fix_isolated-declarations_handle_optional_parameter_properties_in_private_constructors (3cdac4c) with main (3489ce0)¹}

Summary

✅ 34 untouched benchmarks

Footnotes

1. No successful run was found on 07-28-fix_isolated-declarations_crash_when_transforming_a_class_with_a_parameter_property_in_a_private_constructor (4f9cb0b) during the generation of this report, so main (3489ce0) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Boshen]

Merge activity

• Jul 28, 1:22 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 28, 1:22 PM UTC: Boshen added this pull request to the Graphite merge queue.
• Jul 28, 1:32 PM UTC: Merged by the Graphite merge queue.